Lfric2lfric vertical regridding infrastructure#581
Conversation
This reverts commit 599cf12.
|
Hi cjohnson-pi , thank you very much for looping my in here. Unfortunately we can't build |
I think this branch must have changed some code that you are code owner for as github had in fact added you as a reviewer automatically. I'm not sure how to remove you from the list (if anyone knows, please tell me!). At the moment, the protocol for code owners seems to be that github automatically adds you as a reviewer but this doesn't mean you have to do a review. Its just notifying you of work thats going on and if youd like to make some comments you can. I think its just science reviewer and code reviewer that have to do reviews. |
David Lee (davelee2804)
left a comment
There was a problem hiding this comment.
Hi cjohnson-pi , as commented, would you be able to add these lines to:
https://github.com/MetOffice/lfric_apps/blob/main/rose-stem/site/nci/groups/groups_lfric2lfric.cylc#L16
so that we can run these tests at nci via our CI testing pipeline?
| "lfric2lfric_oasis_clim_gal9-C24_C12_6cpu_ex1a_cce_fast-debug-64bit", | ||
| "lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam_1cpu_ex1a_cce_fast-debug-64bit", | ||
| "lfric2lfric_oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_1cpu_ex1a_cce_fast-debug-64bit", | ||
| "lfric2lfric_oasis_C12L70_to_seukL38_ex1a_cce_fast-debug-64bit", |
There was a problem hiding this comment.
Hi cjohnson-pi , would it be possible to add these tests to the nci Rose stem tests as well? Specifically adding the lines:
"lfric2lfric_oasis_C12L70_to_seukL38_gadi_intel_fast-debug-64bit",
"lfric2lfric_oasis_C12L70_to_C12L38_gadi_intel_fast-debug-64bit",
That way we can keep up to date with the Rose stem test coverage as well.
David Lee (davelee2804)
left a comment
There was a problem hiding this comment.
Thanks very much for adding the nci Rose stem tests cjohnson-pi ! much appreciated...
PR Summary
Add the infrastructure required for both horizontal and vertical regridding.
At the moment lfric2lfric can do horizontal regridding. Additional meshes, vertical extrusions, and chi fields (with appropriate orography) are required to enable vertical regridding.
Sci/Tech Reviewer: Lottie Turner (@mo-lottieturner)
Code Reviewer:
is related to vertical regridding kernels #253
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - lfric2lfric_extrusions/run27
Suite Information
Task Information
❌ failed tasks - 5
⌛ waiting tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review